Skip to content

change: replace custom types with Pydantic 2#335

Open
thearchitector wants to merge 32 commits intomasterfrom
elias/pydantic
Open

change: replace custom types with Pydantic 2#335
thearchitector wants to merge 32 commits intomasterfrom
elias/pydantic

Conversation

@thearchitector
Copy link
Contributor

@thearchitector thearchitector commented Oct 4, 2024 •
edited
Loading

Summary

Replacing all the custom type parsing stuff with Pydantic 2.

Based on my existing static typing branch, so that will have to get merged first.

Pydantic parses a few things slightly differently than we were, namely datetimes, so I've patched that validation to ensure backwards compat:

$ docker compose run --rm tester
  py38: OK (13.09=setup[8.93]+cmd[3.34,0.82] seconds)
  py39: OK (12.42=setup[7.22]+cmd[4.04,1.15] seconds)
  py310: OK (12.78=setup[8.52]+cmd[3.37,0.89] seconds)
  py311: OK (11.81=setup[7.50]+cmd[3.23,1.07] seconds)
  py312: OK (11.88=setup[7.30]+cmd[3.57,1.01] seconds)
  congratulations :) (13.15 seconds)

Also fixed some deprecations.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@thearchitector
style: run linters on non-docs
cedd723
@thearchitector
fix: type errors
dbb9bda
@thearchitector
add: typed type utils
c930084
@thearchitector
add: client config typing
04a3f8d
@thearchitector
fix: isort config
1297751
@thearchitector
fix: lint config
f688770
@thearchitector
add: http request typing
d5125e5
@thearchitector
add: generic typing to request/response pipeline
b981e32
@thearchitector
add: typing to http clients
d02eac7
@thearchitector
add: proper return typing to client calls
2f9a2c1
@thearchitector
fix: styling
eb44353
@thearchitector
fix: client and request generic typing
2a98454
@thearchitector
fix: types-ing
9e75e5e
@thearchitector
fix: 50% typing to queries
9dbf2a7
@thearchitector
light at the end of the typed tunnel
e8c3742
@thearchitector
fix: rebase
0c77108
@thearchitector
fix: regressions
f7fc619
@thearchitector
fix: other regressions
bf1660c
@thearchitector
fix: integration test regressions
c9d4a01
@thearchitector
add: typed example
e914692
@thearchitector
fix: cleanup
84fbd0b
@thearchitector
fix: status code and base type check
b04a931
@thearchitector
fix: resposne covariance
1a01585
@thearchitector
fix: add docker tox tester
7945cc3
@thearchitector
add: submission file meta for eml mfs
2e05b7e
@thearchitector
fix: typing for 3.8
c16e83b
@thearchitector
fix: load generic dict scalar fields
7a56f75
@thearchitector
change: convert types to pydantic models
2ea837f
@thearchitector
fix: use legacy datetime parsing
95dd31c
@thearchitector
fix: warnings and deprecations
ab58239
@thearchitector thearchitector requested a review from a team as a code owner October 4, 2024 04:15
@thearchitector thearchitector changed the title change: replace custom typing with Pydantic 2 change: replace custom types with Pydantic 2 Oct 4, 2024
thearchitector
thearchitector commented Oct 4, 2024
View reviewed changes
meghanhickey
meghanhickey previously approved these changes Oct 4, 2024
View reviewed changes
Sung96kim
Sung96kim previously approved these changes Oct 4, 2024
View reviewed changes
@madisonmay
Copy link
Contributor

madisonmay commented Oct 13, 2024

@CodiumAI-Agent /review

@QodoAI-Agent
Copy link

QodoAI-Agent commented Oct 13, 2024 •
edited
Loading

PR Reviewer Guide 🔍

(Review updated until commit cd974c0)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Backward Compatibility
The new header parsing function _parse_header might not handle edge cases as the old cgi.parse_header did. Ensure compatibility and robustness.

Type Validation
The new BaseType class uses Pydantic for validation. Ensure that all necessary validations are correctly ported and that custom validations like _validate_legacy_datetime are correctly implemented.

Field Initialization
The new implementation of the Job class with Pydantic might change how fields are initialized and validated. Ensure that the new field definitions and optional settings do not alter the expected behavior.

@madisonmay
Copy link
Contributor

madisonmay commented Oct 13, 2024 •
edited
Loading

Y'all can ignore this was just curious to test this thing out and needed a PR on a public repo

@QodoAI-Agent
Copy link

QodoAI-Agent commented Oct 13, 2024

Persistent review updated to latest commit cd974c0

@thearchitector
Copy link
Contributor Author

thearchitector commented Oct 13, 2024

Y'all can ignore this was just curious to test this thing out and needed a PR on a public repo

i accept guinea pig status

Base automatically changed from elias/typing to master February 24, 2025 22:01
@thearchitector thearchitector dismissed stale reviews from Sung96kim and meghanhickey February 24, 2025 22:01

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sung96kim Sung96kim Sung96kim left review comments

@meghanhickey meghanhickey meghanhickey left review comments

@nkassis nkassis Awaiting requested review from nkassis

@goatrocks goatrocks Awaiting requested review from goatrocks

@jacobmanderson jacobmanderson Awaiting requested review from jacobmanderson jacobmanderson is a code owner automatically assigned from IndicoDataSolutions/pr-be-indicodata-ai

@nicholas-lockhart nicholas-lockhart Awaiting requested review from nicholas-lockhart nicholas-lockhart is a code owner automatically assigned from IndicoDataSolutions/pr-be-indicodata-ai

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

needs rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thearchitector @madisonmay @QodoAI-Agent @Sung96kim @meghanhickey